Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese Doc duplication and translate it to English #40

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

ninsmiracle
Copy link
Contributor

No description provided.

@acelyc111
Copy link
Member

Hi @ninsmiracle , many thanks for the contribution!

AFAIK, the Chinese docs are a few outdated, for example:
1.

目前在跨机房网络健康的环境下,数据延时大概在 10s 左右,即 A 机房的写数据大概在 10s 后会写入 B 机房。

The 10s can be configured now (by apache/incubator-pegasus#1639), you can add describption like:

Since Pegasus 2.6, it can by configured by xxx
  1. Because FDS is not supported since 2.6, so it would be better to use HDFS as an example to backup data.
  2. Because the metric names have been updated since 2.6, it would be better to distinguish the metric names. Or we can do the update in another patch.
  3. "完整监控项/HTTP 接口列表" can be removed, because it's not "完整的" and it will cost much time to maintenance the doc when code update.

@acelyc111
Copy link
Member

It's recommand to update the Chinese docs at first, then translate it to English to reduce duplicate work.

@ninsmiracle
Copy link
Contributor Author

ninsmiracle commented Dec 15, 2023

目前在跨机房网络健康的环境下,数据延时大概在 10s 左右,即 A 机房的写数据大概在 10s 后会写入 B 机房。

In my opinion,duplication_sync_period_second is the parameter who control the interval time that the duplication info between meta server and replica server. Intead of control the interval of data dup.
Cause we made some latency tests between master duplication cluster and backup duplication cluster.We write some k-v data to master cluster and each of them less than 1KB,Our results showed that the backup duplication cluster was able to read the data in just about 100ms.

@acelyc111
Copy link
Member

目前在跨机房网络健康的环境下,数据延时大概在 10s 左右,即 A 机房的写数据大概在 10s 后会写入 B 机房。

In my opinion,duplication_sync_period_second is the parameter who control the interval time that the duplication info between meta server and replica server. Intead of control the interval of data dup. Cause we made some latency tests between master duplication cluster and backup duplication cluster.We write some k-v data to master cluster and each of them less than 1KB,Our results showed that the backup duplication cluster was able to read the data in just about 100ms.

Thanks for the information! Is it the fixed time interval in https://github.com/apache/incubator-pegasus/blob/master/src/replica/duplication/duplication_pipeline.cpp#L63 ?

The docs is needed to be updated anyway.

@acelyc111
Copy link
Member

@ninsmiracle
Copy link
Contributor Author

THX for the comment and sorrry about the untimely reply. Cause we have too many online failure recently...

@acelyc111 acelyc111 merged commit aa75963 into apache:master Jan 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants