feat: overload stream insertion operator(<<) to support formatting by…

… {fmt} (#1225)

.gitignore

@@ -20,7 +20,6 @@ src/base/rrdb_types.cpp
 src/include/rrdb/rrdb_types.h
 src/common/serialization_helper/dsn.layer2_types.h
 src/runtime/dsn.layer2_types.cpp
-src/runtime
 src/*builder
 
 onebox/

src/common/gpid.h

@@ -26,6 +26,7 @@
 #pragma once
 
 #include <cstdint>
+#include <ostream>
 #include <thrift/protocol/TProtocol.h>
 
 namespace dsn {
@@ -71,9 +72,9 @@ class gpid
 
     int thread_hash() const { return _value.u.app_id * 7919 + _value.u.partition_index; }
 
-    friend std::ostream &operator<<(std::ostream &os, gpid id)
+    friend std::ostream &operator<<(std::ostream &os, const gpid &id)
     {
-        return os << std::string(id.to_string());
+        return os << id.to_string();
     }
 
 private:

src/runtime/rpc/asio_net_provider.cpp

@@ -96,7 +96,7 @@ error_code asio_network_provider::start(rpc_channel channel, int port, bool clie
 
     CHECK(channel == RPC_CHANNEL_TCP || channel == RPC_CHANNEL_UDP,
           "invalid given channel {}",
-          channel.to_string());
+          channel);
 
     _address.assign_ipv4(get_local_ipv4(), port);
 

src/runtime/rpc/network.sim.cpp

@@ -174,7 +174,7 @@ error_code sim_network_provider::start(rpc_channel channel, int port, bool clien
 {
     CHECK(channel == RPC_CHANNEL_TCP || channel == RPC_CHANNEL_UDP,
           "invalid given channel {}",
-          channel.to_string());
+          channel);
 
     _address = ::dsn::rpc_address("localhost", port);
     auto hostname = boost::asio::ip::host_name();

src/runtime/task/task_code.h

@@ -26,6 +26,8 @@
 
 #pragma once
 
+#include <ostream>
+
 #include "utils/ports.h"
 #include "utils/enum_helper.h"
 #include "utils/threadpool_code.h"
@@ -123,7 +125,7 @@ class task_code
 
     friend std::ostream &operator<<(std::ostream &os, const task_code &tc)
     {
-        return os << std::string(tc.to_string());
+        return os << tc.to_string();
     }
 
 private:

src/utils/customizable_id.h

@@ -81,6 +81,11 @@ struct customized_id
     static bool is_exist(const char *name);
     static customized_id from_string(const char *name, customized_id invalid_value);
 
+    friend std::ostream &operator<<(std::ostream &os, const customized_id &id)
+    {
+        return os << id.to_string();
+    }
+
 protected:
     static int assign(const char *xxx);
     customized_id(int code);

src/utils/error_code.h

@@ -26,6 +26,8 @@
 
 #pragma once
 
+#include <ostream>
+
 #include "customizable_id.h"
 #include <thrift/protocol/TProtocol.h>
 
@@ -59,7 +61,7 @@ class error_code
 
     friend std::ostream &operator<<(std::ostream &os, const error_code &ec)
     {
-        return os << std::string(ec.to_string());
+        return os << ec.to_string();
     }
 
 private:

src/utils/threadpool_code.h

@@ -26,6 +26,8 @@
 
 #pragma once
 
+#include <ostream>
+
 #include "ports.h"
 
 namespace dsn {
@@ -49,6 +51,11 @@ class threadpool_code
     static int max();
     static bool is_exist(const char *name);
 
+    friend std::ostream &operator<<(std::ostream &os, const threadpool_code &pool_code)
+    {
+        return os << pool_code.to_string();
+    }
+
 private:
     int _internal_code;
 };