feat(encryption): add kms key management

apache · Dec 6, 2023 · baa1920 · baa1920
1 parent b115e22
commit baa1920
Showing 1 changed file with 3 additions and 17 deletions.
diff --git a/src/replica/replication_app_base.cpp b/src/replica/replication_app_base.cpp
@@ -170,23 +170,9 @@ error_code replica_kms_info::load_json(const std::string &fname)
 
 error_code replica_kms_info::store_json(const std::string &fname)
 {
-    const blob &data = json::json_forwarder<replica_kms_info>::encode(*this);
-    std::string tmp_fname = fname + ".tmp";
-    auto cleanup = defer([tmp_fname]() { utils::filesystem::remove_path(tmp_fname); });
-    auto s =
-        rocksdb::WriteStringToFile(dsn::utils::PegasusEnv(dsn::utils::FileDataType::kNonSensitive),
-                                   rocksdb::Slice(data.data(), data.length()),
-                                   tmp_fname,
-                                   /* should_sync */ true);
-    LOG_AND_RETURN_NOT_TRUE(
-        ERROR, s.ok(), ERR_FILE_OPERATION_FAILED, "write file {} failed", tmp_fname);
-    LOG_AND_RETURN_NOT_TRUE(ERROR,
-                            utils::filesystem::rename_path(tmp_fname, fname),
-                            ERR_FILE_OPERATION_FAILED,
-                            "move file from {} to {} failed",
-                            tmp_fname,
-                            fname);
-    return ERR_OK;
+    return write_blob_to_file(fname,
+                              json::json_forwarder<replica_kms_info>::encode(*this),
+                              dsn::utils::FileDataType::kNonSensitive);
 }
 
 error_code replica_app_info::load(const std::string &fname)