refactor: enable warning on unused result #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empiredan
reviewed
Nov 22, 2022
empiredan
approved these changes
Nov 24, 2022
foreverneverer
approved these changes
Nov 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1166
Deal with function return value to ensure seriours error could be found immediatelly.
You can add macro
WARN_UNUSED_RESULTafter the function declaration to mark the function's return value must be dealt.This patch add the macro and make
command_manager::register_commandasWARN_UNUSED_RESULT, all callers have been refactored to adapt this semantics. It's a guarantee that related objects are destroyed in a meaningful order.