Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rpc_address): simple refactor on rpc_address #1251

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Nov 22, 2022

#1234

Simple refactor before add feature to support FQDN. Including:

  1. move rpc_address.* from src/utils/ to src/runtime/rpc/
  2. move src/utils/test/address.cpp to src/runtime/test/address_test.cpp
  3. add warning log for rpc_group_address.add/remove callers, and will mark TODO to add WARN_UNUSED_RESULT
  4. simple refactor for group_address.h, rpc_address.h|cpp
  5. minimize the include header for rpc_address.h

src/block_service/fds/fds_service.cpp Outdated Show resolved Hide resolved
src/block_service/fds/fds_service.cpp Outdated Show resolved Hide resolved
src/runtime/rpc/group_address.h Outdated Show resolved Hide resolved
src/runtime/rpc/group_address.h Outdated Show resolved Hide resolved
src/runtime/rpc/group_address.h Outdated Show resolved Hide resolved
src/runtime/rpc/rpc_address.cpp Outdated Show resolved Hide resolved
src/runtime/rpc/rpc_address.h Outdated Show resolved Hide resolved
src/runtime/rpc/rpc_address.h Outdated Show resolved Hide resolved
src/runtime/rpc/rpc_address.h Outdated Show resolved Hide resolved
src/utils/utils.h Outdated Show resolved Hide resolved
@acelyc111 acelyc111 merged commit 06a0ad9 into apache:master Dec 1, 2022
@empiredan empiredan mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants