refactor(FLAG): remove the quotes of section field of FLAG #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empiredan
approved these changes
Jan 12, 2023
foreverneverer
approved these changes
Jan 12, 2023
acelyc111
added a commit
to acelyc111/pegasus
that referenced
this pull request
Feb 11, 2023
…field of FLAG (apache#1308)" This reverts commit 966e900.
acelyc111
added a commit
to acelyc111/pegasus
that referenced
this pull request
Feb 11, 2023
…field of FLAG (apache#1308)" This reverts commit 966e900.
acelyc111
added a commit
to acelyc111/pegasus
that referenced
this pull request
Feb 11, 2023
…field of FLAG (apache#1308)" This reverts commit 966e900.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1309
The quotes of DSN_DEFINE_*'s fisrt parameter are useless, we can remove them as how does
gflagdo. Also adds a check when init flags to ensure no one left.