Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(log): use LOG_WARNING_F instead of LOG_WARNING (1/3) #1315

Merged
merged 5 commits into from
Jan 18, 2023
Merged

refactor(log): use LOG_WARNING_F instead of LOG_WARNING (1/3) #1315

merged 5 commits into from
Jan 18, 2023

Conversation

WHBANG
Copy link
Contributor

@WHBANG WHBANG commented Jan 17, 2023 •
edited by acelyc111
Loading

What problem does this PR solve?

#1305

This patch aim to use LOG_WARNING_F instead of LOG_WARNING for replica module. Includes:

  • Use LOG_WARNING_F instead of LOG_WARNING in replica module.
  • Use LOG_WARNING_PREFIX instaed of LOG_WARNING for class replica

@github-actions github-actions bot added the cpp label Jan 17, 2023
@WHBANG WHBANG force-pushed the dev/refactor_log_macros_warn_replica branch from 9237ae8 to 14298f3 Compare January 17, 2023 15:54
@WHBANG WHBANG force-pushed the dev/refactor_log_macros_warn_replica branch from 14298f3 to db205d0 Compare January 17, 2023 15:56
acelyc111
acelyc111 reviewed Jan 17, 2023
View reviewed changes
src/replica/mutation_log.cpp Outdated Show resolved Hide resolved
src/replica/mutation_log.cpp Outdated Show resolved Hide resolved
neverchanje
neverchanje reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@neverchanje neverchanje left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why you used _prefix in several places where _f should be used. Please check the usage carefully, otherwise it would lead to missing information in your logs.

src/replica/replica_check.cpp Show resolved Hide resolved
src/replica/replica_check.cpp Show resolved Hide resolved
src/replica/replica_check.cpp Show resolved Hide resolved
empiredan
empiredan reviewed Jan 18, 2023
View reviewed changes
src/replica/replica_learn.cpp Outdated Show resolved Hide resolved
src/replica/replica_learn.cpp Outdated Show resolved Hide resolved
@empiredan empiredan merged commit f781f6c into apache:master Jan 18, 2023
@acelyc111 acelyc111 mentioned this pull request Jan 28, 2023
Closed
@empiredan empiredan mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelyc111 acelyc111 acelyc111 left review comments

@neverchanje neverchanje neverchanje approved these changes

@empiredan empiredan empiredan approved these changes

Assignees
No one assigned
Labels
cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WHBANG @empiredan @neverchanje @acelyc111