Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(log): use LOG_WARNING_F instead of LOG_WARNING (2/3) #1316

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

WHBANG
Copy link
Contributor

@WHBANG WHBANG commented Jan 17, 2023

What problem does this PR solve?

#1305

This patch aim to use LOG_WARNING_F instead of LOG_WARNING. Includes:

Use LOG_WARNING_F instead of LOG_WARNING in meta module.

@github-actions github-actions bot added the cpp label Jan 17, 2023
src/meta/meta_backup_service.cpp Outdated Show resolved Hide resolved
src/meta/meta_backup_service.cpp Outdated Show resolved Hide resolved
src/meta/server_state.cpp Outdated Show resolved Hide resolved
@WHBANG
Copy link
Contributor Author

WHBANG commented Jan 18, 2023

@neverchanje hi, can you check this pr again, thank you very much.

Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@acelyc111 acelyc111 merged commit 16d9e32 into apache:master Jan 18, 2023
@acelyc111 acelyc111 mentioned this pull request Jan 28, 2023
@empiredan empiredan mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants