Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(conf): use DSN_DEFINE_uint32 to load uint32 type of configs #1352

Merged
merged 4 commits into from
Feb 15, 2023
Merged

refactor(conf): use DSN_DEFINE_uint32 to load uint32 type of configs #1352

merged 4 commits into from
Feb 15, 2023

Conversation

acelyc111
Copy link
Member

#1323

This patch refactor the code to use DSN_DEFINE_uint32 instead of dsn_config_get_value_uint64 to load uint32 type of configurations, and doesn't introduce any functional changes.

  • all default value and most of description are kept as before
  • move the defination of flags closer to the places where they're used

@github-actions github-actions bot added the cpp label Feb 14, 2023
@acelyc111 acelyc111 mentioned this pull request Feb 14, 2023
Closed
levy5307
levy5307 previously approved these changes Feb 15, 2023
View reviewed changes
empiredan
empiredan reviewed Feb 15, 2023
View reviewed changes
src/meta/test/main.cpp Outdated Show resolved Hide resolved
src/runtime/rpc/network.sim.cpp Outdated Show resolved Hide resolved
src/runtime/rpc/rpc_message.cpp Outdated Show resolved Hide resolved
@acelyc111 @empiredan
Update src/meta/test/main.cpp
8ab41c6 
Co-authored-by: Dan Wang <wangdan@apache.org>
acelyc111 and others added 2 commits February 15, 2023 12:35
@acelyc111 @empiredan
Update src/runtime/rpc/network.sim.cpp
7430e60 
Co-authored-by: Dan Wang <wangdan@apache.org>
@acelyc111 @empiredan
Update src/runtime/rpc/rpc_message.cpp
548af2b 
Co-authored-by: Dan Wang <wangdan@apache.org>
@acelyc111 acelyc111 merged commit 4c76112 into apache:master Feb 15, 2023
@empiredan empiredan mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smityz Smityz Smityz approved these changes

@empiredan empiredan empiredan approved these changes

@levy5307 levy5307 levy5307 left review comments

Assignees
No one assigned
Labels
cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acelyc111 @empiredan @levy5307 @Smityz