fix: jaas conf; make thread daemon #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
changed the title
Apache9
reviewed
Mar 15, 2023
| final ScheduledExecutorService service = | ||
| Executors.newSingleThreadScheduledExecutor(new TgtThreadFactory()); | ||
|
|
||
| static class TgtThreadFactory implements ThreadFactory { |
There was a problem hiding this comment.
Just create an anonymous class is enough?
java-client/src/main/java/org/apache/pegasus/security/KerberosProtocol.java
Show resolved
Hide resolved
Apache9
approved these changes
Mar 16, 2023
empiredan
approved these changes
Mar 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #1389
What is changed and how does it work?
Checklist
Tests
Code changes
Side effects
Related changes