fix: fix a crash bug when open an incomplete created RocksDB instance #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
fix_icmpt_rdb
branch
from
75e181e to
e25133b
Compare
acelyc111
force-pushed
the
fix_icmpt_rdb
branch
from
a3f7b0a to
f9be46d
Compare
acelyc111
changed the title
acelyc111
changed the title
acelyc111
changed the title
levy5307
approved these changes
Apr 21, 2023
empiredan
approved these changes
Apr 21, 2023
Closed
GehaFearless
pushed a commit
to GehaFearless/incubator-pegasus
that referenced
this pull request
Feb 28, 2024
…B instance (apache#1451) 对应社区commit: https://github.com/apache/incubator-pegasus/pull/1451/files 注: 由于单测部分变更较大，本次未合入 apache#1450 If replica server attempt to open an incomplete RocksDB instance (maybe caused by a previous crash), it will crash before moving the incomplete path to ".err" trash path, and it will crash again if restart the server. This patch avoid to crash before moving the incomplete RocksDB path to ".err" path, thus the replica has an opportunity to recovery automatically without move the incomplete RocksDB path manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1450
If replica server attempt to open an incomplete RocksDB instance (maybe caused
by a previous crash), it will crash before moving the incomplete path to ".err"
trash path, and it will crash again if restart the server.
This patch avoid to crash before moving the incomplete RocksDB path to ".err" path,
thus the replica has an opportunity to recovery automatically without move the
incomplete RocksDB path manually.