build: add a devcontainer.json #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
acelyc111
previously approved these changes
Jun 25, 2023
|
The "Standardization Lint" is failed https://github.com/apache/incubator-pegasus/actions/runs/5370641850, it's not related to this PR, we can fix it later. But AFAIK, this PR lacks of an issue link and the new added file is needed to be added to |
@Smityz Resolved, please see the latest checks. |
empiredan
approved these changes
Jun 29, 2023
acelyc111
approved these changes
Jun 29, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1549
Support developing inside a container, ref: https://code.visualstudio.com/docs/devcontainers/containers
So that we can develop and compile Pegasus in a docker environment.
I can successfully compile the code in my WSL2 environment.