feat(rocksdb): Support more configurable items for bloom filter #522
+55
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
bits_per_key
for Bloom filter to provide lower false positive rateformat_version
for SST to provide a faster and more accurate Bloom filter implementationWhat is changed and how it works?
Add config in replica server's config.ini:
Check List
Tests
So 99% of these items are not exist, but these point lookups will consult Bloom filters, then negative or positive will be returned by Bloom filters to indicate whether the key is definity not exist or may exist.
point_fp_rate
in shell commandapp_stat
Result
rocksdb_bloom_filter_bits_per_key = 10
androcksdb_format_version = 2
rocksdb_bloom_filter_bits_per_key = 24
androcksdb_format_version = 2
rocksdb_bloom_filter_bits_per_key = 24
androcksdb_format_version = 5
Code changes
No
No
No
Yes
Side effects
No
No
rocksdb_format_version
is2
or5
rocksdb_format_version
is2
Related changes
Yes
Yes
Yes