refactor: split read/write hotspot of hotspot_partition_calculator #592
+202
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
acelyc111
reviewed
Aug 31, 2020
Smityz
force-pushed
the
hotspot-2-formal
branch
from
a182110
to
a5df324
Compare
Smityz
force-pushed
the
hotspot-2-formal
branch
from
a5df324
to
e738ae8
Compare
Smityz
changed the title
Smityz
changed the title
levy5307
reviewed
Sep 11, 2020
levy5307
reviewed
Sep 11, 2020
levy5307
reviewed
Sep 11, 2020
levy5307
reviewed
Sep 11, 2020
hycdong
reviewed
Sep 11, 2020
hycdong
reviewed
Sep 14, 2020
neverchanje
reviewed
Sep 14, 2020
| } | ||
| } | ||
| } | ||
| standard_deviation = sqrt(standard_deviation / (sample_count - 1)); |
There was a problem hiding this comment.
Suggested change
| standard_deviation = sqrt(standard_deviation / (sample_count - 1)); | |
| standard_deviation = sqrt(standard_deviation / (sample_count - 1)); |
(sample_count - 1) Why sub 1?
There was a problem hiding this comment.
According to https://en.wikipedia.org/wiki/Standard_deviation, the denominator in the sample standard deviation formula is N − 1.
Co-authored-by: Wu Tao <wutao1@xiaomi.com>
hycdong
reviewed
Sep 15, 2020
acelyc111
previously approved these changes
Sep 15, 2020
levy5307
reviewed
Sep 16, 2020
levy5307
reviewed
Sep 16, 2020
acelyc111
previously approved these changes
Sep 16, 2020
hycdong
previously approved these changes
Sep 17, 2020
acelyc111
approved these changes
Sep 17, 2020
hycdong
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This submission is mainly to change the data structure of historical partition hotspot statistical and split read/write hotspot of hotspot_partition_calculator
What is changed and how it works?
In the previous design,
_partition_stat_historiessaved instd::queue, which is a bad design.in this PR, I will deprecate the formal data structure, change
queueintolistto save memory copy then split read/write hotpot of statistical, and add some unit tests by the wayFile changes
src/server/hotspot_partition_data.h -> src/server/hotspot_partition_stat.h