fix: full_scan can't scan data completely in some occassions
#825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which client version when encounter the bug? Maybe you can see the replay and make sure if the problem has fixed: |
|
I don't think it's the root cause of the bug. You can fix c++ client by XiaoMi/pegasus-java-client#156 |
levy5307
reviewed
Oct 13, 2021
Smityz
changed the title
full_scan can't scan data completely in some occassions
|
Could you format your code? Otherwise, it can't pass the CI. |
Smityz
reviewed
Oct 13, 2021
levy5307
reviewed
Oct 13, 2021
src/server/pegasus_server_impl.cpp
Outdated
| rd_opts.total_order_seek = true; | ||
| rd_opts.prefix_same_as_start = false; | ||
| } | ||
| if (_data_cf_opts.prefix_extractor && request.full_scan) { |
There was a problem hiding this comment.
This will leads to compatibility issues. For example, if old version client calls new version server(which use request.full_scan to judge whether it is full scan), the full_scan will always be false in request. And full scan can't works well in this situation.
There was a problem hiding this comment.
ok, wait me to change a little
added 3 commits
October 13, 2021 16:10
|
LGTM |
levy5307
approved these changes
Oct 13, 2021
Smityz
approved these changes
Oct 13, 2021
Closed
hycdong
pushed a commit
that referenced
this pull request
Oct 27, 2021
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#824
What is changed and how does it work?
The previous server-side on_get_scanners function judged whether it is full_scan or non-full_scan by whether the start_key in the request structure is filled with hash_key, which will cause a bug in the issue; the way to fix here is to directly add a field to the request structure to determine
Test
manual test