-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(collector): fix unexpected crash #984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
当某张表 partition 为 1 时,可能导致 stat_histories_analyse 提前 return,进而 hot_points 和 _hot_points size 不一致,使得后续的 assert fail ` D2022-05-28 06:29:48.34 (1653719388034076919 383) collector.default1.0101000000000001: compiler_depend.ts:108:stat_histories_analyse(): _partitions_stat_histories size <= 1, not enough data for calculation F2022-05-28 06:29:48.34 (1653719388034089894 383) collector.default1.0101000000000001: compiler_depend.ts:135:update_hot_point(): assertion expression: _hot_points.size() == hot_points.size() F2022-05-28 06:29:48.34 (1653719388034125236 383) collector.default1.0101000000000001: compiler_depend.ts:135:update_hot_point(): 1 vs 0 `
felixdae
changed the title
fix: fix collector crash
fix(collector): fix unexpected crash
May 28, 2022
acelyc111
reviewed
May 29, 2022
As the failed GitHub check actions shown, could you plz create an issue to report this bug? |
as reviewer suggested
acelyc111
previously approved these changes
May 29, 2022
acelyc111
approved these changes
May 29, 2022
Smityz
approved these changes
May 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#985 (comment)
What problem does this PR solve?
当某张表 partition 为 1 时,可能导致 stat_histories_analyse 提前 return,进而 hot_points 和 _hot_points size 不一致,使得后续的 assert fail
What is changed and how does it work?
将 hot_points 的 resize 提前到函数入口处,确保其 size 和 _hot_points 的 size 一致
Checklist
Tests
Code changes
Side effects
Related changes