Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: rename module name to seata.apache.org/seata-go #678

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

luky116
Copy link
Contributor

@luky116 luky116 commented Mar 16, 2024

What this PR does:

Which issue(s) this PR fixes:

Fixes #662

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@wt-better
Copy link
Contributor

I think we need to fix 'seata-go' character to 'apache-seata-go(incubating)' . exmaple CONTRIBUTING.md、coverrage、changenotes

@luky116
Copy link
Contributor Author

luky116 commented Mar 16, 2024

I think we need to fix 'seata-go' character to 'apache-seata-go(incubating)' . exmaple CONTRIBUTING.md、coverrage、changenotes

all done

CONTRIBUTING.md Outdated
upstream no-pushing (push)
```

Adding this, we can easily synchronize local branches with upstream branches.

### Branch Definition

Right now we assume every contribution via pull request is for [branch develop](https://github.com/seata/seata-go/tree/develop) in seata-go. Before contributing, be aware of branch definition would help a lot.
Right now we assume every contribution via pull request is for [branch develop](https://github.com/apache/seata-go/tree/develop) in seata-go. Before contributing, be aware of branch definition would help a lot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the replacement related to the documentation, I believe it is necessary to use apache/incubator-seata-go to ensure the URL is accessible. It is recommended to replace it module by module.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with the documentation here, it should be the dev branch, not develop.
At the same time, the dev branch and the master branch are lagging far behind, and I think they should be maintained.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with the documentation here, it should be the dev branch, not develop. At the same time, the dev branch and the master branch are lagging far behind, and I think they should be maintained.
i have changed it to master

@luky116
Copy link
Contributor Author

luky116 commented Apr 13, 2024

coverrage

you mean this to github.com/apache/apache-seata-go?

image

it may cause some error, because https://github.com/apache/apache-seata-go can not access

image

@wt-better
Copy link
Contributor

@AlexStocks
Copy link
Contributor

@luky116 这个 PR 蛮久了,加快推动下吧

@luky116
Copy link
Contributor Author

luky116 commented May 25, 2024

'https://github.com/seata/seata-go/tree/develop' maybe change to 'https://github.com/apache/incubator-seata-go/tree/develop'
It might be better to keep it consistent with the seata project
image

@slievrly slievrly changed the title rename module name to seata.apache.org/seata-go optimize: rename module name to seata.apache.org/seata-go Jun 4, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit ad092d5 into apache:master Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename seata-go module name
4 participants