-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: rename module name to seata.apache.org/seata-go #678
Conversation
I think we need to fix 'seata-go' character to 'apache-seata-go(incubating)' . exmaple CONTRIBUTING.md、coverrage、changenotes |
all done |
CONTRIBUTING.md
Outdated
upstream no-pushing (push) | ||
``` | ||
|
||
Adding this, we can easily synchronize local branches with upstream branches. | ||
|
||
### Branch Definition | ||
|
||
Right now we assume every contribution via pull request is for [branch develop](https://github.com/seata/seata-go/tree/develop) in seata-go. Before contributing, be aware of branch definition would help a lot. | ||
Right now we assume every contribution via pull request is for [branch develop](https://github.com/apache/seata-go/tree/develop) in seata-go. Before contributing, be aware of branch definition would help a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the replacement related to the documentation, I believe it is necessary to use apache/incubator-seata-go to ensure the URL is accessible. It is recommended to replace it module by module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a problem with the documentation here, it should be the dev branch, not develop.
At the same time, the dev branch and the master branch are lagging far behind, and I think they should be maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/apache/seata-go will redirect to https://github.com/apache/incubator-seata-go, it is setted in github
https://github.com/apache/seata-go will redirect to https://github.com/apache/incubator-seata-go, it is setted in github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a problem with the documentation here, it should be the dev branch, not develop. At the same time, the dev branch and the master branch are lagging far behind, and I think they should be maintained.
i have changed it to master
you mean this to github.com/apache/apache-seata-go? it may cause some error, because https://github.com/apache/apache-seata-go can not access |
@luky116 这个 PR 蛮久了,加快推动下吧 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Which issue(s) this PR fixes:
Fixes #662
Special notes for your reviewer:
Does this PR introduce a user-facing change?: