-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: only the inserted fields are checked #3890
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3890 +/- ##
==========================================
Coverage 40.79% 40.79%
- Complexity 3059 3061 +2
==========================================
Files 682 682
Lines 22887 22896 +9
Branches 2842 2844 +2
==========================================
+ Hits 9336 9340 +4
- Misses 12679 12685 +6
+ Partials 872 871 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seata-go: apache/incubator-seata-go#697 |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #3891
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews