-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: Only AT mode try to get channel with other app #5153
Conversation
server/src/main/java/io/seata/server/coordinator/AbstractCore.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #5153 +/- ##
=============================================
+ Coverage 48.48% 48.88% +0.40%
- Complexity 4139 4170 +31
=============================================
Files 743 743
Lines 26520 26521 +1
Branches 3294 3294
=============================================
+ Hits 12857 12964 +107
+ Misses 12263 12154 -109
- Partials 1400 1403 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
tcc模式下,resourceid如果不能保证全局唯一,有可能导致路由错误(TC调用了错误的RM).
这个pr判断branchtype,只有AT模式才允许tryOtherApp
Ⅱ. Does this pull request fix one issue?
fixes #5130
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews