Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Only AT mode try to get channel with other app #5153

Merged
merged 8 commits into from
Jan 17, 2023

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Dec 14, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

tcc模式下,resourceid如果不能保证全局唯一,有可能导致路由错误(TC调用了错误的RM).
这个pr判断branchtype,只有AT模式才允许tryOtherApp

Ⅱ. Does this pull request fix one issue?

fixes #5130

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 1.6.1 milestone Dec 14, 2022
@slievrly slievrly removed this from the 1.6.1 milestone Dec 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #5153 (21b02dc) into develop (d19cfee) will increase coverage by 0.40%.
The diff coverage is 40.00%.

❗ Current head 21b02dc differs from pull request most recent head 165e3aa. Consider uploading reports for the commit 165e3aa to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5153      +/-   ##
=============================================
+ Coverage      48.48%   48.88%   +0.40%     
- Complexity      4139     4170      +31     
=============================================
  Files            743      743              
  Lines          26520    26521       +1     
  Branches        3294     3294              
=============================================
+ Hits           12857    12964     +107     
+ Misses         12263    12154     -109     
- Partials        1400     1403       +3     
Impacted Files Coverage Δ
...ta/core/rpc/netty/AbstractNettyRemotingServer.java 0.00% <0.00%> (ø)
...n/java/io/seata/core/rpc/netty/ChannelManager.java 0.00% <0.00%> (ø)
...in/java/io/seata/server/session/BranchSession.java 78.57% <0.00%> (-0.57%) ⬇️
...java/io/seata/server/coordinator/AbstractCore.java 55.05% <100.00%> (ø)
...a/io/seata/rm/datasource/xa/ResourceManagerXA.java 8.95% <0.00%> (-11.95%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...ource/sql/struct/cache/AbstractTableMetaCache.java 89.65% <0.00%> (-3.45%) ⬇️
...r/console/impl/file/GlobalLockFileServiceImpl.java 94.87% <0.00%> (-2.57%) ⬇️
...a/io/seata/rm/datasource/xa/DataSourceProxyXA.java 71.11% <0.00%> (-2.23%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
... and 9 more

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title Only AT mode try to get channel with other app optimize: Only AT mode try to get channel with other app Dec 29, 2022
@funky-eyes funky-eyes added this to the 2.0.0 milestone Jan 17, 2023
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit a84bbcc into apache:develop Jan 17, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCC mode , same resourceId may lead to incorrect routing
6 participants