-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix getConfig
throw ClassCastException
when use JDK proxy
#5239
Conversation
getConfig
throw CastException
getConfig
throw ClassCastException
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5239 +/- ##
=============================================
- Coverage 48.85% 48.70% -0.15%
+ Complexity 4165 4156 -9
=============================================
Files 743 743
Lines 26536 26588 +52
Branches 3301 3320 +19
=============================================
- Hits 12964 12951 -13
- Misses 12164 12239 +75
+ Partials 1408 1398 -10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
getConfig
throw ClassCastException
getConfig
throw ClassCastException
, and optimize some log
getConfig
throw ClassCastException
, and optimize some loggetConfig
throw ClassCastException
on native-image
, and optimize some log
getConfig
throw ClassCastException
on native-image
, and optimize some loggetConfig
throw ClassCastException
when use jdk proxy, and optimize some log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
getConfig
throw ClassCastException
when use jdk proxy, and optimize some loggetConfig
throw ClassCastException
when use JDK proxy, and optimize some log
getConfig
throw ClassCastException
when use JDK proxy, and optimize some loggetConfig
throw ClassCastException
when use JDK proxy
try { | ||
result = getDefaultValueFromPropertyObject(dataId); | ||
} catch (Throwable t) { | ||
LOGGER.error("Get config '{}' default value from the property object failed:", dataId, t); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the previous configuration priority, the priority of the value object is greater than the default value priority of the parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The object is no longer a spring bean, so I think the priority is no longer higher than the arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
bugfix: fix
getConfig
throwClassCastException
when use JDK proxy, and optimize some log.BUG修复:修复当使用JDK代理时,
getConfig
方法获取部分配置时抛出ClassCastException
异常的问题,另外顺便优化了几处日志。Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews