optimize: refactor ColumnUtils and EscapeHandler #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
l81893521
reviewed
Mar 29, 2023
rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/oracle/OracleEscapeHandler.java
Show resolved
Hide resolved
Signed-off-by: slievrly <slievrly@163.com>
…20_01 # Conflicts: # changes/en-us/2.0.0.md # changes/zh-cn/2.0.0.md
slievrly
changed the title
liuqiufeng
pushed a commit
to liuqiufeng/seata
that referenced
this pull request
Apr 20, 2023
1 task
Bughue
added a commit
to Bughue/seata
that referenced
this pull request
Nov 7, 2023
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mariadb/MariadbEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mysql/MySQLEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/oracle/OracleEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/postgresql/PostgresqlEscapeHandler.java # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.EscapeHandler # rm-datasource/src/test/java/io/seata/rm/datasource/ColumnUtilsTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/sql/handler/EscapeHandlerTest.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeHandler.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeSymbol.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/KeywordChecker.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/util/ColumnUtils.java
Bughue
added a commit
to Bughue/seata
that referenced
this pull request
Nov 7, 2023
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mariadb/MariadbEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mysql/MySQLEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/oracle/OracleEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/postgresql/PostgresqlEscapeHandler.java # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.EscapeHandler # rm-datasource/src/test/java/io/seata/rm/datasource/ColumnUtilsTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/sql/handler/EscapeHandlerTest.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeHandler.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeSymbol.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/KeywordChecker.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/util/ColumnUtils.java
Bughue
added a commit
to Bughue/seata
that referenced
this pull request
Nov 7, 2023
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mariadb/MariadbEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mysql/MySQLEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/oracle/OracleEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/postgresql/PostgresqlEscapeHandler.java # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.EscapeHandler # rm-datasource/src/test/java/io/seata/rm/datasource/ColumnUtilsTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/sql/handler/EscapeHandlerTest.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeHandler.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeSymbol.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/KeywordChecker.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/util/ColumnUtils.java
Bughue
added a commit
to Bughue/seata
that referenced
this pull request
Nov 7, 2023
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mariadb/MariadbEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mysql/MySQLEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/oracle/OracleEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/postgresql/PostgresqlEscapeHandler.java # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.EscapeHandler # rm-datasource/src/test/java/io/seata/rm/datasource/ColumnUtilsTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/sql/handler/EscapeHandlerTest.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeHandler.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeSymbol.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/KeywordChecker.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/util/ColumnUtils.java
Bughue
added a commit
to Bughue/seata
that referenced
this pull request
Nov 9, 2023
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mariadb/MariadbEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mysql/MySQLEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/oracle/OracleEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/postgresql/PostgresqlEscapeHandler.java # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.EscapeHandler # rm-datasource/src/test/java/io/seata/rm/datasource/ColumnUtilsTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/sql/handler/EscapeHandlerTest.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeHandler.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeSymbol.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/KeywordChecker.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/util/ColumnUtils.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
refactor ColumnUtils
step1:
sink database-related functions in ColumnUtils.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews