bugfix: fix TC retry rollback wrongly, after the XA transaction fail and rollback #5833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5833 +/- ##
=============================================
+ Coverage 48.80% 48.88% +0.07%
- Complexity 4165 4172 +7
=============================================
Files 793 793
Lines 28003 28003
Branches 3417 3417
=============================================
+ Hits 13668 13690 +22
+ Misses 12911 12889 -22
Partials 1424 1424
|
funky-eyes
reviewed
Sep 8, 2023
rm-datasource/src/main/java/io/seata/rm/datasource/xa/ConnectionProxyXA.java
Outdated
Show resolved
Hide resolved
funky-eyes
added
type: bug
已补充 |
jsbxyyx
reviewed
Sep 25, 2023
| DefaultResourceManager.get().branchReport(BranchType.XA, xid, xaBranchXid.getBranchId(), | ||
| status, null); | ||
| } catch (TransactionException te) { | ||
| LOGGER.warn("Failed to report XA branch " + status + " on " + xid + "-" + xaBranchXid.getBranchId() |
There was a problem hiding this comment.
use log placeholder {}
already modified
slievrly
reviewed
Oct 8, 2023
There are other situations that can also cause XAException, so RM needs to return Retryable to TC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
修复bug #5832 。当XA分支事务回滚后，报告给TC，避免TC不知道重试回滚
Ⅱ. Does this pull request fix one issue?
fixes #5832
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews