Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: dm escaped characters for upper and lower case column names #5884

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Sep 26, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5883

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@wangliang181230 wangliang181230 linked an issue Sep 26, 2023 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #5884 (5e6f0da) into develop (27c0228) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5884      +/-   ##
=============================================
- Coverage      48.94%   48.86%   -0.08%     
+ Complexity      4166     4157       -9     
=============================================
  Files            777      777              
  Lines          27944    27955      +11     
  Branches        3412     3416       +4     
=============================================
- Hits           13677    13661      -16     
- Misses         12849    12874      +25     
- Partials        1418     1420       +2     
Files Coverage Δ
.../rm/datasource/sql/handler/dm/DmEscapeHandler.java 96.30% <0.00%> (-1.60%) ⬇️

... and 6 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 1.8.0 milestone Sep 26, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels Sep 26, 2023
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit e96ea8f into apache:develop Sep 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

达梦数据库开启大小写区分后,seata无法正常使用。
3 participants