Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove mariadb.jdbc dependency #5891

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

remove mariadb.jdbc dependency

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 1.8.0 milestone Sep 28, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #5891 (6b6fad7) into develop (378f8d3) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5891      +/-   ##
=============================================
- Coverage      48.77%   48.76%   -0.01%     
+ Complexity      4133     4129       -4     
=============================================
  Files            775      775              
  Lines          27913    27913              
  Branches        3410     3410              
=============================================
- Hits           13614    13612       -2     
- Misses         12875    12877       +2     
  Partials        1424     1424              

see 9 files with indirect coverage changes

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly merged commit da21423 into apache:develop Sep 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Finished
Development

Successfully merging this pull request may close these issues.

2 participants