-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support polardb-x 2.0 #5892
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5892 +/- ##
=============================================
+ Coverage 48.75% 48.81% +0.06%
- Complexity 4128 4166 +38
=============================================
Files 775 793 +18
Lines 27924 28003 +79
Branches 3414 3417 +3
=============================================
+ Hits 13613 13671 +58
- Misses 12885 12907 +22
+ Partials 1426 1425 -1
|
* | ||
* @param connection db connection | ||
*/ | ||
private void testMySQLAdaptiveType(Connection connection) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method names need to be more standardized, generally only UT will use the test name.
* @param dbType origin db type | ||
* @return adaptive db type | ||
*/ | ||
private static String getAdaptiveDbType(String dbType) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect a common class to determine if it's a MySQL family of databases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Extending AT mode support for PolarDB-X 2.0.
Note: Transparent PolarDB-X support is currently available only in the form of MySQL inheritance, and DRDS partitioning may need to be supported in the future.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews