Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize change log #5906

Merged

Conversation

wangliang181230
Copy link
Contributor

optimize: optimize change log

@wangliang181230 wangliang181230 changed the base branch from 2.x to develop October 7, 2023 03:04
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #5906 (14ffa09) into develop (357f8e8) will increase coverage by 0.09%.
Report is 78 commits behind head on develop.
The diff coverage is 70.03%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5906      +/-   ##
=============================================
+ Coverage      48.79%   48.89%   +0.09%     
+ Complexity      4176     4174       -2     
=============================================
  Files            743      793      +50     
  Lines          26617    28003    +1386     
  Branches        3327     3417      +90     
=============================================
+ Hits           12989    13691     +702     
- Misses         12225    12886     +661     
- Partials        1403     1426      +23     
Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <ø> (ø)
.../src/main/java/io/seata/common/util/BlobUtils.java 60.00% <100.00%> (ø)
...n/src/main/java/io/seata/common/util/PageUtil.java 50.00% <ø> (ø)
...ava/io/seata/compressor/deflater/DeflaterUtil.java 80.64% <100.00%> (ø)
.../main/java/io/seata/config/ConfigurationCache.java 73.33% <100.00%> (-0.75%) ⬇️
...c/main/java/io/seata/core/context/RootContext.java 46.77% <ø> (ø)
...seata/core/exception/TransactionExceptionCode.java 100.00% <100.00%> (ø)
...o/seata/core/protocol/AbstractIdentifyRequest.java 78.57% <100.00%> (+8.57%) ⬆️
.../seata/core/protocol/AbstractIdentifyResponse.java 75.00% <100.00%> (-6.49%) ⬇️
... and 116 more

... and 73 files with indirect coverage changes

@@ -80,7 +80,7 @@ jobs:
# step 4
- name: "Test with Maven"
run: |
./mvnw -T 4C clean test -Dspring-boot.version=${{ matrix.springboot }} -Dspring-boot-for-server.version=2.5.14 -Dspring-framework-for-server.version=5.3.20 -Dkotlin-maven-plugin.version=1.7.22 -Dcheckstyle.skip=false -Dlicense.skip=false -e -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn;
./mvnw -T 4C clean test -Dspring-boot.version=${{ matrix.springboot }} -Dspring-boot-for-server.version=2.5.14 -Dspring-framework-for-server.version=5.3.20 -Dkotlin-maven-plugin.version=1.7.22 -Dcheckstyle.skip=true -Dlicense.skip=true -e -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上次改错了。

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 351b108 into apache:develop Oct 7, 2023
8 checks passed
@wangliang181230 wangliang181230 deleted the optimize-change-log-for-develop branch October 7, 2023 05:55
@wangliang181230 wangliang181230 added this to the Other Branchs milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants