Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs about Seata configuration files #5913

Closed
wants to merge 0 commits into from

Conversation

meteor-01
Copy link

…tion center and registry

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Add comments on logs and parameters related to nacos as the configuration center and registry

Ⅱ. Does this pull request fix one issue?

fixes #5608

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #5913 (f50000a) into 2.x (8984880) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5913      +/-   ##
============================================
+ Coverage     49.01%   49.04%   +0.02%     
- Complexity     4777     4783       +6     
============================================
  Files           913      913              
  Lines         31710    31710              
  Branches       3827     3827              
============================================
+ Hits          15542    15551       +9     
+ Misses        14627    14623       -4     
+ Partials       1541     1536       -5     

see 4 files with indirect coverage changes

username: nacos
password: nacos
# for the path of nacos health check, you need to configure an open web endpoint
context-path: /${server.servlet.context-path}/actuator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default value is ${server.servlet.context-path}/actuator ? It's not a health check as I understand it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reply.
Sorry, I misunderstood. I intend to make the following changes:
username: nacos
password: nacos
# used to specify the context path in the URL, forming the complete access path, which is empty by default.
# the full URL is: :// ${server.ip}:${server.port} / ${context-path} /
# if the IP address of the server is 192.168.1.1, the port number is 7091, the context is set to /seata,
# and the client wants to initiate a request for /info, then the complete URL is as follows:
# http://192.168.1.1:7091/seata/info
context-path:

what do you think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can modify on this basis, and I will continue to review the modified code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confused about the documentation [important]
2 participants