-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the issue of missing sentinel password in store redis mode #5931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeppaO check style failed.
done |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5931 +/- ##
==========================================
Coverage 48.86% 48.86%
- Complexity 4171 4172 +1
==========================================
Files 793 793
Lines 28003 28007 +4
Branches 3417 3417
==========================================
+ Hits 13683 13685 +2
+ Misses 12895 12894 -1
- Partials 1425 1428 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
当store.redis.mode=sentinel时,设置哨兵密码时,代码中缺少哨兵密码
Ⅱ. Does this pull request fix one issue?
#4161
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews