-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: support jmx port in seata #5939
Conversation
sync #5938 to develop branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to register the githubid in develop.md
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5939 +/- ##
=============================================
- Coverage 48.86% 48.83% -0.03%
+ Complexity 4171 4167 -4
=============================================
Files 793 793
Lines 28003 28003
Branches 3417 3417
=============================================
- Hits 13683 13676 -7
- Misses 12895 12901 +6
- Partials 1425 1426 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5269
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
export JMX_ENABLE=true
Ⅴ. Special notes for reviews