-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix zookeeper UT failed #5960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5960 +/- ##
=============================================
- Coverage 48.81% 48.48% -0.34%
+ Complexity 4164 4145 -19
=============================================
Files 793 793
Lines 28007 28007
Branches 3417 3417
=============================================
- Hits 13672 13578 -94
- Misses 12911 13009 +98
+ Partials 1424 1420 -4 |
first round: https://github.com/seata/seata/actions/runs/6639838130/job/18039020531?pr=5960 I will retry the CICD workflow. |
slievrly
changed the title
[WIP]test: try fix zookeeper UT failed
test: fix zookeeper UT failed
Oct 25, 2023
funky-eyes
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: slievrly <slievrly@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
try fix zookeeper UT failed
Ⅱ. Does this pull request fix one issue?
fixes #5923
fixes #5952
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews