Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix zookeeper UT failed #5960

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Oct 25, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

try fix zookeeper UT failed

Ⅱ. Does this pull request fix one issue?

fixes #5923

fixes #5952

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #5960 (1aba21a) into develop (046e384) will decrease coverage by 0.34%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5960      +/-   ##
=============================================
- Coverage      48.81%   48.48%   -0.34%     
+ Complexity      4164     4145      -19     
=============================================
  Files            793      793              
  Lines          28007    28007              
  Branches        3417     3417              
=============================================
- Hits           13672    13578      -94     
- Misses         12911    13009      +98     
+ Partials        1424     1420       -4     

see 10 files with indirect coverage changes

@slievrly
Copy link
Member Author

first round: https://github.com/seata/seata/actions/runs/6639838130/job/18039020531?pr=5960

I will retry the CICD workflow.

@slievrly
Copy link
Member Author

@slievrly
Copy link
Member Author

@slievrly
Copy link
Member Author

all the check pass.
image

@slievrly slievrly changed the title [WIP]test: try fix zookeeper UT failed test: fix zookeeper UT failed Oct 25, 2023
@slievrly slievrly added this to the 1.8.0 milestone Oct 25, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly merged commit 3c8a9e3 into apache:develop Oct 26, 2023
8 checks passed
@slievrly slievrly mentioned this pull request Oct 26, 2023
1 task
@slievrly slievrly mentioned this pull request Oct 31, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants