Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix incorrect metric report #6026

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

ptyin
Copy link
Member

@ptyin ptyin commented Nov 12, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Same as #6018, whereas fix this in develop branch.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #6026 (a94c7fb) into develop (b556e94) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #6026      +/-   ##
=============================================
- Coverage      48.98%   48.87%   -0.11%     
+ Complexity      4194     4184      -10     
=============================================
  Files            793      793              
  Lines          28028    28028              
  Branches        3423     3423              
=============================================
- Hits           13729    13700      -29     
- Misses         12870    12898      +28     
- Partials        1429     1430       +1     
Files Coverage Δ
...in/java/io/seata/server/session/SessionHelper.java 60.34% <100.00%> (ø)

... and 9 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add change in develop.md(zh-cn/en-us)

@slievrly slievrly added this to the 1.8.1 milestone Nov 12, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module labels Nov 13, 2023
@funky-eyes funky-eyes merged commit c829e73 into apache:develop Nov 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants