-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix hsf isReference bug #6033
bugfix: fix hsf isReference bug #6033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6033 +/- ##
============================================
+ Coverage 49.56% 49.57% +0.01%
- Complexity 4748 4749 +1
============================================
Files 907 907
Lines 31284 31284
Branches 3770 3770
============================================
+ Hits 15506 15510 +4
+ Misses 14246 14244 -2
+ Partials 1532 1530 -2
|
RemotingFactoryBeanParser生效流程: 2.x版本中,GlobalTransactionScanner实际会把所有的FactoryBean类型都在扫描中过滤掉,而直接对FactoryBean生产的目标bean做解析是无法判断为rpc reference的,因此需要RemotingFactoryBeanParser来处理。 HSFRemotingParser中原先的判断("com.taobao.hsf.app.spring.util.HSFSpringConsumerBean".equals(beanClassName) || "org.springframework.beans.factory.FactoryBean".equals(beanClassName)); 其中 该pr内容在hsf环境下测试通过。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
image
在使用了hsf框架的环境下,任何FactoryBean实例都会被该方法判断为true
fixes #6032