-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: upgrade springboot and spring version for server #6052
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6052 +/- ##
============================================
- Coverage 49.57% 49.49% -0.09%
- Complexity 4751 4752 +1
============================================
Files 907 908 +1
Lines 31295 31354 +59
Branches 3773 3777 +4
============================================
+ Hits 15515 15519 +4
- Misses 14247 14302 +55
Partials 1533 1533 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to skip the server module as it is a binary package or image and does not involve adapting to different versions of Spring.
… of further unit testing of console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6051
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews