Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: The TCC aspect does not handle internal invocation exceptions and directly throws them externally. #6090

Merged
merged 6 commits into from
Dec 1, 2023
Merged

bugfix: The TCC aspect does not handle internal invocation exceptions and directly throws them externally. #6090

merged 6 commits into from
Dec 1, 2023

Conversation

leezongjie
Copy link
Contributor

@leezongjie leezongjie commented Nov 27, 2023 •
edited by funky-eyes
Loading

2.x版本中支持去spring能力，对切面部分做了重构处理，如果tcc一二阶段rpc调用过程出现异常，会多加一层框架内部异常，部分业务之前会严格校验rpc调用产生的原生异常，这样会导致原判断失效不成立。为了兼容做处理，直接将异常抛出。

fixes #6084

@leezongjie leezongjie changed the title [fix] The TCC aspect does not handle internal invocation exceptions and directly throws them externally. fix：The TCC aspect does not handle internal invocation exceptions and directly throws them externally. Nov 27, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Merging #6090 (89daba5) into 2.x (b2ac653) will increase coverage by 0.03%.
The diff coverage is 75.00%.

❗ Current head 89daba5 differs from pull request most recent head 411a706. Consider uploading reports for the commit 411a706 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6090      +/-   ##
============================================
+ Coverage     49.23%   49.27%   +0.03%     
- Complexity     4790     4799       +9     
============================================
  Files           913      913              
  Lines         31677    31685       +8     
  Branches       3824     3825       +1     
============================================
+ Hits          15597    15613      +16     
+ Misses        14535    14523      -12     
- Partials       1545     1549       +4
Files Coverage Δ
...ta/spring/annotation/AdapterInvocationWrapper.java 62.50% <100.00%> (+62.50%) ⬆️
...n/tx/api/interceptor/DefaultInvocationWrapper.java 80.00% <66.66%> (+10.76%) ⬆️

... and 6 files with indirect coverage changes

@funky-eyes funky-eyes changed the title fix：The TCC aspect does not handle internal invocation exceptions and directly throws them externally. bugfix: The TCC aspect does not handle internal invocation exceptions and directly throws them externally. Nov 28, 2023
@funky-eyes funky-eyes added this to the 2.1.0 milestone Nov 28, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/tcc tcc module module/intergration-tx-api intergration-tx-api labels Nov 28, 2023
funky-eyes
funky-eyes reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议补充一个测试用例，证明其不再是runtimeexception
It is recommended to add a test case to prove that it is no longer a RuntimeException

@leizhiyuan leizhiyuan self-requested a review November 28, 2023 06:09
leizhiyuan
leizhiyuan approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others is ok

@funky-eyes funky-eyes closed this Nov 29, 2023
@funky-eyes funky-eyes reopened this Nov 29, 2023
@leezongjie
Merge branch '2.x' into fix_Exception_Catch_BUG
89daba5 
# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
funky-eyes
funky-eyes approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes closed this Nov 30, 2023
@funky-eyes funky-eyes reopened this Nov 30, 2023
@leezongjie
Merge branch '2.x' into fix_Exception_Catch_BUG
411a706 
# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
@funky-eyes funky-eyes merged commit f42fb72 into apache:2.x Dec 1, 2023
7 checks passed
slievrly
slievrly reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

l81893521 pushed a commit to l81893521/seata that referenced this pull request Dec 2, 2023
@leezongjie @l81893521
bugfix: The TCC aspect does not handle internal invocation exceptions…
7d957e5 
… and directly throws them externally. (apache#6090)
@open-digger-bot open-digger-bot bot mentioned this pull request Dec 4, 2023
Closed
@funky-eyes funky-eyes mentioned this pull request Dec 15, 2023
Open
@funky-eyes funky-eyes mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly left review comments

@leizhiyuan leizhiyuan leizhiyuan approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees
No one assigned
Labels
module/intergration-tx-api intergration-tx-api module/tcc tcc module type: bug Category issues or prs related to bug.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Seata 2.0.0 Exception Catch BUG
4 participants
@leezongjie @leizhiyuan @slievrly @funky-eyes