Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add workflow for MacOS and Windows #6151

Merged
merged 9 commits into from
Dec 14, 2023

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Dec 14, 2023

Same as #6081 in 2.x branch


测试成功日志(Test success log):

https://github.com/wangliang181230/seata/actions?query=branch%3Atest-optimize

@wangliang181230 wangliang181230 changed the base branch from 2.x to develop December 14, 2023 02:43
@wangliang181230 wangliang181230 changed the title test: add test for MacOS and Windows test: add test for MacOS and Windows Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #6151 (46b5afa) into develop (0710c64) will decrease coverage by 0.06%.
Report is 1 commits behind head on develop.
The diff coverage is 17.07%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #6151      +/-   ##
=============================================
- Coverage      48.85%   48.79%   -0.06%     
- Complexity      4184     4186       +2     
=============================================
  Files            794      794              
  Lines          28054    28084      +30     
  Branches        3426     3427       +1     
=============================================
- Hits           13705    13704       -1     
- Misses         12910    12944      +34     
+ Partials        1439     1436       -3     
Files Coverage Δ
...ta/discovery/registry/FileRegistryServiceImpl.java 0.00% <0.00%> (ø)
...ta/core/rpc/netty/AbstractNettyRemotingClient.java 18.71% <33.33%> (+0.18%) ⬆️
...ta/core/serializer/SerializerSecurityRegistry.java 54.44% <16.21%> (-28.89%) ⬇️

... and 11 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title test: add test for MacOS and Windows workflow: add workflow for MacOS and Windows Dec 14, 2023
@slievrly slievrly changed the title workflow: add workflow for MacOS and Windows optimize: add workflow for MacOS and Windows Dec 14, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants