Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "optimize: the high CPU usage issue of the rpcMergeMessageSend thread (#6061) #6163

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #6163 (5f8505d) into 2.x (5563492) will increase coverage by 0.00%.
The diff coverage is 45.83%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6163   +/-   ##
=========================================
  Coverage     48.94%   48.95%           
- Complexity     4775     4776    +1     
=========================================
  Files           913      913           
  Lines         31710    31697   -13     
  Branches       3827     3823    -4     
=========================================
- Hits          15521    15517    -4     
+ Misses        14653    14638   -15     
- Partials       1536     1542    +6     
Files Coverage Δ
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 14.28% <100.00%> (ø)
...ta/core/rpc/netty/AbstractNettyRemotingClient.java 18.71% <43.47%> (+0.20%) ⬆️

... and 6 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants