Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove authentication from the health check page #6356

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

remove authentication from the health check page

Ⅱ. Does this pull request fix one issue?

fixes #6351

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

image

Ⅴ. Special notes for reviews

@slievrly slievrly changed the title bugfix: remove authentication from the health check page optimize: remove authentication from the health check page Feb 19, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Feb 20, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10bcd0f) 52.38% compared to head (ba2e9ba) 52.38%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6356   +/-   ##
=========================================
  Coverage     52.38%   52.38%           
+ Complexity     5216     5215    -1     
=========================================
  Files           920      920           
  Lines         31924    31924           
  Branches       3807     3807           
=========================================
+ Hits          16722    16723    +1     
+ Misses        13554    13550    -4     
- Partials       1648     1651    +3     

see 3 files with indirect coverage changes

Copy link
Contributor

@liuqiufeng liuqiufeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuqiufeng liuqiufeng merged commit b852a6c into apache:2.x Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The documentation lacks information related to the authentication of Docker Image’s 7091 port
4 participants