Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add the default console and security config on application.examle.yml #6732

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

hmj776521114
Copy link
Contributor

Ⅰ. Describe what this PR did

add the default console and security config on application.examle.yml(#6725)

Ⅱ. Does this pull request fix one issue?

fixes #6725

Ⅲ. Why don't you add test cases (unit test/integration test)?

it donnot need

Ⅳ. Describe how to verify it

unzip the seata-server.zip, and rename application.yml to application.yml.bak, application.example.yml to application.yml on seata-server. then execute the seata-server.sh shell script, check whether startup successfully.

Ⅴ. Special notes for reviews

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的 已补充

@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 6, 2024
@funky-eyes
Copy link
Contributor

changes 下的2.x.md 中英两个版本都要登记下pr信息和作者信息。
Please register pull request information and author details in both the English and Chinese versions of the 2.x.md file located in the changes folder.

@hmj776521114
Copy link
Contributor Author

changes 下的2.x.md 中英两个版本都要登记下pr信息和作者信息。 Please register pull request information and author details in both the English and Chinese versions of the 2.x.md file located in the changes folder.

okay, all done.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title optimize: add the default console and security config on application.examle.yml(#6725) optimize: add the default console and security config on application.examle.yml Aug 6, 2024
@funky-eyes funky-eyes added the module/server server module label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.76%. Comparing base (c1515ac) to head (3eb90a0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6732      +/-   ##
============================================
- Coverage     50.84%   50.76%   -0.08%     
+ Complexity     5914     5899      -15     
============================================
  Files          1058     1058              
  Lines         36717    36717              
  Branches       4364     4364              
============================================
- Hits          18669    18641      -28     
- Misses        16161    16189      +28     
  Partials       1887     1887              

see 14 files with indirect coverage changes

@funky-eyes funky-eyes merged commit 005ac0b into apache:2.x Aug 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

建议在application.example.yml文件中加上console.*和security.*配置
2 participants