-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: add the default console and security config on application.examle.yml #6732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/apache/incubator-seata/blob/2.x/server/src/main/resources/application.raft.example.yml
应该也要进行补充
It should also be supplemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的 已补充
changes 下的2.x.md 中英两个版本都要登记下pr信息和作者信息。 |
okay, all done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6732 +/- ##
============================================
- Coverage 50.84% 50.76% -0.08%
+ Complexity 5914 5899 -15
============================================
Files 1058 1058
Lines 36717 36717
Branches 4364 4364
============================================
- Hits 18669 18641 -28
- Misses 16161 16189 +28
Partials 1887 1887 |
Ⅰ. Describe what this PR did
add the default console and security config on application.examle.yml(#6725)
Ⅱ. Does this pull request fix one issue?
fixes #6725
Ⅲ. Why don't you add test cases (unit test/integration test)?
it donnot need
Ⅳ. Describe how to verify it
unzip the seata-server.zip, and rename
application.yml
toapplication.yml.bak
,application.example.yml
toapplication.yml
onseata-server
. then execute theseata-server.sh
shell script, check whether startup successfully.Ⅴ. Special notes for reviews