Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove the branch registration operation of the XA read-only transaction #6826

Merged
merged 8 commits into from
Sep 21, 2024

Conversation

GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Sep 7, 2024

…n and other related operations

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

XA模式下。如果是只读事务就不注册分支及xa的任何操作
In XA mode, if it is a read-only transaction, the branch and any operation of xa will not be registered.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Manually set the connection's readOnly to true or set the annotation @transactional(readOnly = true) in the Spring framework

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.34%. Comparing base (be01fb0) to head (3abdbbe).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ache/seata/rm/datasource/xa/ConnectionProxyXA.java 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6826      +/-   ##
============================================
+ Coverage     52.30%   52.34%   +0.03%     
- Complexity     6405     6421      +16     
============================================
  Files          1083     1083              
  Lines         37846    37916      +70     
  Branches       4489     4495       +6     
============================================
+ Hits          19795    19846      +51     
- Misses        16081    16097      +16     
- Partials       1970     1973       +3     
Files with missing lines Coverage Δ
...ache/seata/rm/datasource/xa/ConnectionProxyXA.java 56.97% <60.00%> (+1.94%) ⬆️

... and 6 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.x Backlog milestone Sep 8, 2024
@funky-eyes funky-eyes added mode: XA XA transaction mode module/rm-datasource rm-datasource module type: optimize labels Sep 8, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes modified the milestones: 2.x Backlog, 2.3.0 Sep 12, 2024
@funky-eyes funky-eyes merged commit f5b897e into apache:2.x Sep 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: XA XA transaction mode module/rm-datasource rm-datasource module type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants