-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: spring boot compatible with file.conf and registry.conf (#6811) #6828
Open
lyl2008dsg
wants to merge
13
commits into
apache:2.x
Choose a base branch
from
smartscity:feature_compatible_conf
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyl2008dsg
changed the title
compatible with file.conf and registry.conf (#6811)
spring 吧、oot compatible with file.conf and registry.conf (#6811)
Sep 7, 2024
lyl2008dsg
changed the title
spring 吧、oot compatible with file.conf and registry.conf (#6811)
spring boot compatible with file.conf and registry.conf (#6811)
Sep 7, 2024
funky-eyes
reviewed
Sep 8, 2024
...java/org/apache/seata/spring/boot/autoconfigure/provider/SeataFileConfigurationProvider.java
Outdated
Show resolved
Hide resolved
lyl2008dsg
commented
Sep 8, 2024
...e/src/main/java/org/apache/seata/spring/boot/autoconfigure/loader/SeataPropertiesLoader.java
Show resolved
Hide resolved
slievrly
reviewed
Sep 8, 2024
...src/test/java/org/apache/seata/spring/boot/autoconfigure/SeataCoreAutoConfigurationTest.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Sep 8, 2024
...e/src/main/java/org/apache/seata/spring/boot/autoconfigure/loader/SeataPropertiesLoader.java
Outdated
Show resolved
Hide resolved
…orElse for setting system properties.
…ation loading test.
…ng from file.conf and registry.conf
funky-eyes
changed the title
spring boot compatible with file.conf and registry.conf (#6811)
optimize: spring boot compatible with file.conf and registry.conf (#6811)
Sep 9, 2024
funky-eyes
added
type: optimize
module/server
server module
module/seata-spring-autoconfigure-client
module/test
test module
labels
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module/seata-spring-autoconfigure-client
module/server
server module
module/test
test module
type: optimize
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This PR implements a new class
SeataFileConfigurationProvider
in theseata-spring-autoconfigure-core
module. This change ensures that bothseata-spring-boot-starter
andseata-spring-autoconfigure-server
can read legacy configuration files (file.conf
andregistry.conf
), addressing an issue where users upgrading from Spring to Spring Boot would only have their configuration loaded, causing confusion.Ⅱ. Does this pull request fix one issue?
fixed #6811
This PR addresses the issue where
seata-spring-boot-starter
fails to loadfile.conf
andregistry.conf
when users upgrade from Spring to Spring Boot.Ⅲ. Why don't you add test cases (unit test/integration test)?
org.apache.seata.spring.boot.autoconfigure.SeataCoreAutoConfigurationTest
Ⅳ. Describe how to verify it
seata-spring-boot-starter
in a Spring Boot application.file.conf
andregistry.conf
are correctly loaded alongside configurations.seata-spring-boot-starter
andseata-spring-autoconfigure-server
environments.Ⅴ. Special notes for reviews