-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: use curator instead of zkclient in registry model #6831
Conversation
…feat/curator_config_zk
…feat/curator_config_zk
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6831 +/- ##
============================================
+ Coverage 52.30% 52.33% +0.02%
- Complexity 6405 6416 +11
============================================
Files 1083 1083
Lines 37846 37913 +67
Branches 4489 4492 +3
============================================
+ Hits 19795 19841 +46
- Misses 16081 16103 +22
+ Partials 1970 1969 -1
|
ZkConfigurationTest.testRemoveConfig:119 expected: but was: |
...ry-zk/src/main/java/org/apache/seata/discovery/registry/zk/ZookeeperRegisterServiceImpl.java
Outdated
Show resolved
Hide resolved
...ry-zk/src/main/java/org/apache/seata/discovery/registry/zk/ZookeeperRegisterServiceImpl.java
Show resolved
Hide resolved
…scovery/registry/zk/ZookeeperRegisterServiceImpl.java
…scovery/registry/zk/ZookeeperRegisterServiceImpl.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fixes #6772
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
there has been
Ⅳ. Describe how to verify it
ZookeeperRegisterServiceImplTest
Ⅴ. Special notes for reviews
merge after #6779