Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove incompatible licenses at build time #6905

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Oct 9, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

remove incompatible licenses at build time

Ⅱ. Does this pull request fix one issue?

fix #6804

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.54%. Comparing base (5752786) to head (740bb46).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6905      +/-   ##
============================================
- Coverage     52.55%   52.54%   -0.01%     
+ Complexity     6545     6544       -1     
============================================
  Files          1122     1122              
  Lines         39857    39857              
  Branches       4668     4670       +2     
============================================
- Hits          20945    20943       -2     
- Misses        16918    16921       +3     
+ Partials       1994     1993       -1     

see 1 file with indirect coverage changes

@funky-eyes funky-eyes modified the milestones: 2.2.0, 2.3.0 Oct 12, 2024
@funky-eyes funky-eyes merged commit 87c1696 into apache:2.x Oct 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove CC-BY-4.0 license from source code
2 participants