-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: expand unit test coverage for the [rocketmq] module. #6927
Open
psxjoy
wants to merge
13
commits into
apache:2.x
Choose a base branch
from
psxjoy:rocketmq-unit-test
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6927 +/- ##
============================================
+ Coverage 51.80% 51.93% +0.12%
- Complexity 6462 6473 +11
============================================
Files 1122 1122
Lines 39857 39860 +3
Branches 4668 4670 +2
============================================
+ Hits 20649 20701 +52
+ Misses 17248 17194 -54
- Partials 1960 1965 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add unit test cases to complete the unit testing objectives for the
seata-rocketmq
module.增加单元测试用例,完成 rocketmq模块的单元测试目标
Ⅱ. Does this pull request fix one issue?
fix #6506
Ⅲ. Why don't you add test cases (unit test/integration test)?
Not applicate
不适用
Ⅳ. Describe how to verify it
Run
mvn clean test
Ⅴ. Special notes for reviews
In the
SeataMQProducer
class, there's a methoddoSendMessageInTransaction
, which calls the parent class methodsend(Message msg, long timeout)
. Since Mockito can't mock certain parent methods, the functionality has been refactored to ensure the unit test coverage exceeds 70%. The changes are as follows:SeataMQProducer
类中有个函数doSendMessageInTransaction
,里面调用了父类的函数send(Message msg, long timeout)
。因为Mockit 无法模拟父类的某些方法,为了单元测试用例覆盖率达到70%以上,进行了拆分。具体的修改为:
Before
After