-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reactor: remove dependency on seata-server module #7017
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7017 +/- ##
============================================
- Coverage 52.64% 52.62% -0.02%
- Complexity 6595 6596 +1
============================================
Files 1126 1126
Lines 40020 40020
Branches 4700 4698 -2
============================================
- Hits 21070 21062 -8
- Misses 16938 16952 +14
+ Partials 2012 2006 -6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependencies中的grpc版本是否应该也改为1.55.1?
Should the version of gRPC in the dependencies also be updated to 1.55.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
remove dependency on seata-server module
Ⅱ. Does this pull request fix one issue?
fix #6882
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews