Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactor: remove dependency on seata-server module #7017

Merged
merged 15 commits into from
Nov 28, 2024

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Nov 19, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

remove dependency on seata-server module

Ⅱ. Does this pull request fix one issue?

fix #6882

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.62%. Comparing base (5fe6da6) to head (a030529).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7017      +/-   ##
============================================
- Coverage     52.64%   52.62%   -0.02%     
- Complexity     6595     6596       +1     
============================================
  Files          1126     1126              
  Lines         40020    40020              
  Branches       4700     4698       -2     
============================================
- Hits          21070    21062       -8     
- Misses        16938    16952      +14     
+ Partials       2012     2006       -6     

see 3 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.3.0 milestone Nov 26, 2024
@funky-eyes funky-eyes added the type: refactor refactor module label Nov 26, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependencies中的grpc版本是否应该也改为1.55.1?
Should the version of gRPC in the dependencies also be updated to 1.55.1?

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 556a734 into apache:2.x Nov 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor refactor module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org.apache.seata:seata-mock-server depends on the non-existent org.apache.seata:seata-server
2 participants