This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Add SSL argument to Impala shell #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just appends ssl on the end of the impala shell command. This runs without the ca_cert argument, which I think should be fine in most cases.
inthecards67
approved these changes
Sep 2, 2020
jfn6030217
approved these changes
Sep 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SPOT-308. This just appends ssl on the end of the impala shell command. This runs without the ca_cert argument, which I think should be fine in most cases.
I didn't update beeline since the spot.conf sort of implies that the JDBC connection string should include kerberos and ssl arguments before hand. I also ignored the Hive shell, but we should just think about deprecating that whole piece of the code anyway since beeline is more widely supported to connect to Hive.
We should also probably revisit just rewriting this whole thing as a python interface at some point so that we're not maintaining so many versions of the same commands, ddls, etc.