Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Flink-Submit] Fixed security issues with submitting external applications to manipulate the Jvm #3659

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

zhilinli123
Copy link
Contributor

@zhilinli123 zhilinli123 commented Apr 8, 2024

What changes were proposed in this pull request

issues:
Many frameworks restrict the passing of external parameters, and it is possible for the user to accidentally forget to pass them in. This is an actual problem that I have encountered, and it is a dangerous operation that has caused my streampark service jvm to fail directly in the past

  public static void main(String[] args) throws Exception {
        if (args.length < 1) {
            logger.error("Missing configuration file!");
            System.exit(1);
        } 

    }

Before repair

image

After repair

image

@wolfboys
Copy link
Member

wolfboys commented Apr 8, 2024

Thanks for your contribution, I will review it later

@github-actions github-actions bot added FLINK and removed BACKEND labels Apr 10, 2024
@zhilinli123
Copy link
Contributor Author

PTAL: @wolfboys thanks !

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants