Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Flink-Submit][dev-2.1.4]Fixed security issues with submitting external applications to manipulate the Jvm #3661

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[Bug][Flink-Submit][dev-2.1.4]Fixed security issues with submitting external applications to manipulate the Jvm #3661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions ...park-flink-client-api/src/main/scala/org/apache/streampark/flink/client/FlinkClient.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,10 @@ import org.apache.streampark.common.util.Logger
import org.apache.streampark.flink.client.bean._
import org.apache.streampark.flink.proxy.FlinkShimsProxy

import java.security.Permission

import scala.language.{implicitConversions, reflectiveCalls}
import scala.reflect.ClassTag

object FlinkClient extends Logger {

private[this] val FLINK_CLIENT_HANDLER_CLASS_NAME =
Expand All @@ -46,7 +47,13 @@ object FlinkClient extends Logger {
"org.apache.streampark.flink.client.bean.TriggerSavepointRequest" -> "triggerSavepoint"

def submit(submitRequest: SubmitRequest): SubmitResponse = {
proxy[SubmitResponse](submitRequest, submitRequest.flinkVersion, SUBMIT_REQUEST)
val securityManager = System.getSecurityManager
try {
System.setSecurityManager(new ExitSecurityManager())
proxy[SubmitResponse](submitRequest, submitRequest.flinkVersion, SUBMIT_REQUEST)
} finally {
System.setSecurityManager(securityManager)
}
}

def cancel(stopRequest: CancelRequest): CancelResponse = {
Expand Down Expand Up @@ -87,3 +94,13 @@ object FlinkClient extends Logger {
}

}

/** Used to mask JVM requests for external operations */
class ExitSecurityManager extends SecurityManager {
override def checkExit(status: Int): Unit = {
throw new SecurityException(
s"System.exit($status) was called in your flink job, The job has been stopped, please check your program...")
}

override def checkPermission(perm: Permission): Unit = {}
}
Loading