feat(sankey-viz): allow sort by metric and bump superset-ui packages #11626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11626 +/- ##
===========================================
- Coverage 65.29% 54.64% -10.66%
===========================================
Files 873 406 -467
Lines 42289 14320 -27969
Branches 3964 3683 -281
===========================================
- Hits 27613 7825 -19788
+ Misses 14550 6327 -8223
- Partials 126 168 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
force-pushed
the
sankey-sort-limit
branch
from
7ad850e to
4685da7
Compare
6 tasks
ktmud
force-pushed
the
sankey-sort-limit
branch
from
4685da7 to
bfbef1d
Compare
ktmud
changed the title
|
@ktmud very strange. Well, let's get this merged and see what happens when I rebase the boxplot PR. |
etr2460
approved these changes
Nov 10, 2020
| @@ -1854,6 +1854,8 @@ def query_obj(self) -> QueryObjectDict: | |||
| _("Pick exactly 2 columns as [Source / Target]") | |||
| ) | |||
| qry["metrics"] = [self.form_data["metric"]] | |||
| if self.form_data.get("sort_by_metric", False): | |||
There was a problem hiding this comment.
you don't need the False here, it'll default to None which is falsey
There was a problem hiding this comment.
I thought supplying a default helps indicating this parameter is a boolean.
Since CI is green, I think I'll leave it.
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allow sankey chart to sort by metric and bump superset-ui packages to bring in multiple changes by @etr2460 and @villebro :
Diff: apache-superset/superset-ui@v0.15.10...v0.15.13
TEST PLAN
Manual and CI
ADDITIONAL INFORMATION