Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superset issue #4512: multiple metrics, group by, opacity, legends for histogram #4525

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

ArielStv
Copy link
Contributor

@ArielStv ArielStv commented Mar 3, 2018

Trying to address issue #4512 and going further than PR #4513.

This PR gives the ability to have multiple histograms in the same chart. Features added:

  • select multiple numeric columns (one histogram per column)
  • add a group by (one histogram per group and column)
  • legends: I used nvd3 legends for consistency with other superset viz using nvd3
  • opacity option: with multiple histograms, it is sometimes nice to have a lower opacity for readability.

There could be a case for using nvd3 for histograms. I looked into it quickly and it didn't seem obvious to me how to make it work in a simple way. I'm also not a big fan of the multiBarChart feature (there is a PR opened for this though - #3777 - not sure where it's at).

Further possible improvements: better way of assigning bin numbers and bar widths across groups (right now, all groups are assigned the same number of bins, and width is computed accordingly), align bars on the x-axis, assign one distinct opacity value per group.

screen shot 2018-03-02 at 5 50 51 pm

Of note: the group-by option here is different from the group-by option for other viz: there is no aggregation function applied. Instead, the 'raw' data for each group is used to plot the histograms.

@ArielStv
Copy link
Contributor Author

ArielStv commented Mar 3, 2018

@ArielStv
Copy link
Contributor Author

ArielStv commented Mar 3, 2018

Also, if you guys do decide to merge this, maybe we should change the thumbnail for the histogram viz?

@SpyderRivera
Copy link
Contributor

This is very cool

@rumbin
Copy link
Contributor

rumbin commented Mar 19, 2018

I love it!

Any chance to get this PR merged before the next release?

@ArielStv
Copy link
Contributor Author

@mistercrunch would you mind taking a look at it? I'd be happy to keep working on it if need be.

@mistercrunch
Copy link
Member

@ArielStv, I finally took the time to pull the branch and play with this. This is solid, merging!

@mistercrunch mistercrunch merged commit adf9ec0 into apache:master Apr 11, 2018
@SpyderRivera
Copy link
Contributor

bitmoji

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@nicholasgcoles
Copy link

@mistercrunch was this functionality deprecated at some point? Or does it require a custom configuration of sorts?

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants