Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve histogram viz #4512

Closed
ArielStv opened this issue Mar 1, 2018 · 6 comments
Closed

Improve histogram viz #4512

ArielStv opened this issue Mar 1, 2018 · 6 comments
Labels
inactive Inactive for >= 30 days

Comments

@ArielStv
Copy link
Contributor

ArielStv commented Mar 1, 2018

This issue aims to encapsulate issues #3674, #988 (and in a larger sense #989 and PR #3777).

As it is, the histogram feature doesn't look good with large numbers of bins: the x-ticks, y-ticks, colors and annotations make it unintelligible, and even with a small number of bins, it's not great (in my opinion). It seems to have been an ongoing concern when looking at previous open issues.

I'd like to change that, and take advantage of the opportunity to improve the histogram further.

The thing is, I'm not sure how much the histogram viz is used at the moment. I couldn't find any examples from Superset (or anywhere else) so I'm assuming not much? I'd be interested to know how people are actually using it, since I couldn't find a good use case for it.

If that's the case, we can most likely go on and make changes and improvements on the current histogram feature without worrying too much about breaking stuff for users.
Otherwise, maybe it'd be better to create a new visualization?

I assumed the former for a first pass. I'm going to make 2 pull requests (that I will link below):

  • the first one only fixes the basic issues: color, ticks, x-axis label, normalization option, get rid of text on bars
  • the second one (based on the first) goes further and is more involved: it allows for multiple histograms in one chart through selecting multiple numeric columns or through a group by (or both). I've also added legends and an opacity option.
@ArielStv
Copy link
Contributor Author

ArielStv commented Mar 1, 2018

First pull request: #4513

superset_pr_screenshot

@williaster
Copy link
Contributor

williaster commented Mar 1, 2018

if you're considering updating the vis a lot, you might consider @data-ui/histogram which supports some of the features you've mentioned out of the box (we have some interest in using @data-ui for other charts)

@ArielStv
Copy link
Contributor Author

ArielStv commented Mar 1, 2018

Looks great! I'll look into it

graceguo-supercat pushed a commit that referenced this issue Mar 2, 2018
* fixing histogram axes and colors, adding normalized and x-axis label options

* adding y-axis label option
@ArielStv
Copy link
Contributor Author

ArielStv commented Mar 3, 2018

#4513 being merged, I opened a new pull request: #4525. Let me know what you think!

screen shot 2018-03-02 at 5 50 51 pm

michellethomas pushed a commit to michellethomas/panoramix that referenced this issue May 24, 2018
* fixing histogram axes and colors, adding normalized and x-axis label options

* adding y-axis label option
wenchma pushed a commit to wenchma/incubator-superset that referenced this issue Nov 16, 2018
* fixing histogram axes and colors, adding normalized and x-axis label options

* adding y-axis label option
@stale
Copy link

stale bot commented Apr 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 11, 2019
@stale stale bot closed this as completed Apr 18, 2019
@nicholasgcoles
Copy link

@ArielStv I am struggling to find current documentation to implement this graph.

Was it deprecated? Or is there some custom work that needs to be done to use this kind of visualisation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

3 participants